KDE/danbooru-client
1
0
Fork 0
Code Issues Pull requests Releases Activity

Get rid of QPixmap pointers

Browse source 
According to my understanding of Qt documentation, there should be no need to
manually create QPixmap with new and delete. This also makes things simpler for the model.
This commit is contained in:
Luca Beltrame 2014-08-28 09:19:20 +02:00
parent dafe9d2c3e
commit 061251bc26
2 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/libdanbooru/danboorupost.cpp
View file

@ -38,7 +38,7 @@ namespace Danbooru {
const QMap<QString, Rating> DanbooruPost::RATING_MAP = initRatingMap();
DanbooruPost::DanbooruPost(QVariantMap postData, QPixmap* pixmap,
DanbooruPost::DanbooruPost(QVariantMap postData, QPixmap pixmap,
QObject* parent):
QObject(parent),
m_pixmap(pixmap)
@ -56,9 +56,7 @@ namespace Danbooru {
}
DanbooruPost::DanbooruPost(QXmlStreamAttributes& postData,
QPixmap* pixmap,
QObject* parent):
DanbooruPost::DanbooruPost(QXmlStreamAttributes& postData, QPixmap pixmap, QObject* parent):
QObject(parent),
m_pixmap(pixmap)
{
@ -101,7 +99,7 @@ namespace Danbooru {
}
void DanbooruPost::setPixmap(const QPixmap* pixmap)
void DanbooruPost::setPixmap(const QPixmap pixmap)
{
m_pixmap = pixmap;
}
@ -138,7 +136,7 @@ namespace Danbooru {
return m_thumbnailUrl;
}
const QPixmap* DanbooruPost::pixmap() const
const QPixmap DanbooruPost::pixmap() const
{
return m_pixmap;
}