KDE/danbooru-client
1
0
Fork 0
Code Issues Pull requests Releases Activity

Switch to QVector instead of QList. Insertions aren't really needed.

Browse source
This commit is contained in:
Luca Beltrame 2013-07-20 11:44:27 +02:00
parent cfbfef9651
commit 1886dbf53c
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/libdanbooru/danboorupost.cpp
View file

@ -78,6 +78,7 @@ namespace Danbooru {
DanbooruPost::~DanbooruPost()
{
delete m_pixmap;
m_pixmap = 0;
}

8
src/model/danboorutablemodel.cpp
View file

@ -40,18 +40,19 @@ namespace Danbooru {
DanbooruTableModel::~DanbooruTableModel()
{
qDeleteAll(m_posts);
m_posts.clear();
}
int DanbooruTableModel::rowCount(const QModelIndex& parent) const
{
Q_UNUSED(parent)
return m_posts.length();
return m_posts.size();
}
void DanbooruTableModel::addPost(Danbooru::DanbooruPost* post)
{
beginInsertRows(QModelIndex(), m_posts.length(), m_posts.length() + 1);
beginInsertRows(QModelIndex(), m_posts.size(), m_posts.size() + 1);
m_posts.append(post);
endInsertRows();
}
@ -60,11 +61,10 @@ namespace Danbooru {
{
if (!index.isValid()) {
return QVariant();
}
if (index.row() >= m_posts.length() || index.row() < 0) {
if (index.row() >= m_posts.size() || index.row() < 0) {
return QVariant();
}

4
src/model/danboorutablemodel.h
View file

@ -30,7 +30,7 @@
**/
#include <QAbstractListModel>
#include <QList>
#include <QVector>
namespace Danbooru {
@ -59,7 +59,7 @@ namespace Danbooru {
QVariant data(const QModelIndex& index, int role) const;
private:
QList<DanbooruPost*> m_posts;
QVector<DanbooruPost*> m_posts;
public Q_SLOTS:
/**