Switch to QVector instead of QList. Insertions aren't really needed.

This commit is contained in:
Luca Beltrame 2013-07-20 11:44:27 +02:00
parent cfbfef9651
commit 1886dbf53c
3 changed files with 7 additions and 6 deletions

View file

@ -78,6 +78,7 @@ namespace Danbooru {
DanbooruPost::~DanbooruPost() DanbooruPost::~DanbooruPost()
{ {
delete m_pixmap; delete m_pixmap;
m_pixmap = 0;
} }

View file

@ -40,18 +40,19 @@ namespace Danbooru {
DanbooruTableModel::~DanbooruTableModel() DanbooruTableModel::~DanbooruTableModel()
{ {
qDeleteAll(m_posts); qDeleteAll(m_posts);
m_posts.clear();
} }
int DanbooruTableModel::rowCount(const QModelIndex& parent) const int DanbooruTableModel::rowCount(const QModelIndex& parent) const
{ {
Q_UNUSED(parent) Q_UNUSED(parent)
return m_posts.length(); return m_posts.size();
} }
void DanbooruTableModel::addPost(Danbooru::DanbooruPost* post) void DanbooruTableModel::addPost(Danbooru::DanbooruPost* post)
{ {
beginInsertRows(QModelIndex(), m_posts.length(), m_posts.length() + 1); beginInsertRows(QModelIndex(), m_posts.size(), m_posts.size() + 1);
m_posts.append(post); m_posts.append(post);
endInsertRows(); endInsertRows();
} }
@ -60,11 +61,10 @@ namespace Danbooru {
{ {
if (!index.isValid()) { if (!index.isValid()) {
return QVariant(); return QVariant();
} }
if (index.row() >= m_posts.length() || index.row() < 0) { if (index.row() >= m_posts.size() || index.row() < 0) {
return QVariant(); return QVariant();
} }

View file

@ -30,7 +30,7 @@
**/ **/
#include <QAbstractListModel> #include <QAbstractListModel>
#include <QList> #include <QVector>
namespace Danbooru { namespace Danbooru {
@ -59,7 +59,7 @@ namespace Danbooru {
QVariant data(const QModelIndex& index, int role) const; QVariant data(const QModelIndex& index, int role) const;
private: private:
QList<DanbooruPost*> m_posts; QVector<DanbooruPost*> m_posts;
public Q_SLOTS: public Q_SLOTS:
/** /**