From b951cddee4c8ad0c4a3f6980e0fe67adb948c61a Mon Sep 17 00:00:00 2001 From: Luca Beltrame Date: Sun, 15 Feb 2015 22:05:17 +0100 Subject: [PATCH] Put a TODO for "password salts" The way Danbooru handles passwords is simplistic to stay the least. It's also impossible to know the "password salt" without visiting the API page. As such, "salts" need to be put along with the board they originate from. The code doesn't handle missing keys, hence this TODO. --- src/danbooruconnectwidget.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/danbooruconnectwidget.cpp b/src/danbooruconnectwidget.cpp index 780eefc..3b235a7 100644 --- a/src/danbooruconnectwidget.cpp +++ b/src/danbooruconnectwidget.cpp @@ -130,6 +130,7 @@ void DanbooruConnectWidget::getWalletData() QString hashedPassword; + // TODO: Handle the case where the "salt" is not known hashedPassword = boardSalts.value(key); hashedPassword = hashedPassword.arg(valueMap[QLatin1String("password")]);