From 3e8c404fdf7701b174b9d958448948b24d7decbc Mon Sep 17 00:00:00 2001 From: Luca Beltrame Date: Tue, 23 Oct 2018 11:43:20 +0200 Subject: [PATCH] Make sure the hash is only updated when osc succeeds --- update_unstable.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/update_unstable.py b/update_unstable.py index f64d931..672bc9b 100755 --- a/update_unstable.py +++ b/update_unstable.py @@ -80,8 +80,10 @@ def run_osc(repository, package_name): if pid.returncode != 0: logging.error("Error during service run, package {}".format( package_name)) + return False logging.debug("Package {} complete".format(package_name)) + return True def update_package(hash_data, package_name, remote_name, obs_repository, @@ -104,10 +106,10 @@ def update_package(hash_data, package_name, remote_name, obs_repository, if remote_hash != current_hash: logging.debug("Hash doesn't match, updating") - run_osc(obs_repository, package_name) - hash_data[obs_repository][remote_name] = remote_hash - hash_data.save() - hash_data.to_json() + if run_osc(obs_repository, package_name): + hash_data[obs_repository][remote_name] = remote_hash + hash_data.save() + hash_data.to_json() def update_packages(cache_file, repo_mapping_file):