websites/dennogumi.org-archive
Archived
1
0
Fork 0
Code Releases Activity

Fix ordering of "heroes"

Browse source
This commit is contained in:
Luca Beltrame 2016-10-29 17:55:24 +02:00
parent e45c90e167
commit e818fbb0bc
Signed by: einar
GPG key ID: 40C8281493B01C16
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
_posts/2016-10-29-the-heroes-we-deserve.markdown
View file

@ -35,7 +35,7 @@ One major problem with this issue was that not all NVIDIA cards were affected. O
But two of our today's heroes did not give up. Martin and Antonio sat around a virtual table and tried to work out a solution. Martin suggested to use the same mechanism that KWin used normally to determine if the use of OpenGL is "unsafe" when starting up, disabling it if any problems arose. It didn't work in the specific case only because the freeze occurred when rendering started, that is past this checkpoint.
The discussion was fruitful. Across the several hypotheses mentioned, Fabian Vogt, also from the openSUSE KDE team, thought about a "dead man's switch": KWin would get killed and restarted if a freeze occurred, but disabling OpenGL after the restart. That was enough for Antonio and Martin to come up with a strategy: checking with a timer if KWin was frozen during rendering. If the timer went off, KWin would get killed and restarted automatically, but disabling OpenGL (more technically, activating the "OpenGL unsafe protection"), and now would be able to continue without freezes. Antonio [posted his patch for review](https://phabricator.kde.org/D3132) and that is where we meet our third hero of the day, David "d_ed" Edmundson. During the patch review, he asked Antonio what kind of card exhibited the issue, and promptly acted to get one to run tests himself.
The discussion was fruitful. Across the several hypotheses mentioned, Fabian Vogt, also from the openSUSE KDE team, thought about a "dead man's switch": KWin would get killed and restarted if a freeze occurred, but disabling OpenGL after the restart. That was enough for Antonio and Martin to come up with a strategy: checking with a timer if KWin was frozen during rendering. If the timer went off, KWin would get killed and restarted automatically, but disabling OpenGL (more technically, activating the "OpenGL unsafe protection"), and now would be able to continue without freezes. Antonio [posted his patch for review](https://phabricator.kde.org/D3132) and that is where we meet another hero of the day, David "d_ed" Edmundson. During the patch review, he asked Antonio what kind of card exhibited the issue, and promptly acted to get one to run tests himself.
Patches went back and forth for a number of days, scrapping one solution after the other, until Martin was finally able to accept the final revision, which was merged by Antonio in the Plasma/5.8 branch of kwin (meaning, everyone will benefit from it). Fabian then proceeded [to submit these patches to openSUSE Leap](https://build.opensuse.org/request/show/437190) and to [openSUSE Tumbleweed](https://build.opensuse.org/request/show/437189).